PoC: Add rewrite support for errorprone.refasterrules
#2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
force-pushed
the
fix-rewrite-unused
branch
from
0cfc8f7 to
1c476d0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Pankraz76
force-pushed
the
fix-rewrite-unused
branch
from
1c476d0 to
bdf8f28
Compare
Pankraz76
commented
Jul 23, 2025
Pankraz76
commented
Jul 23, 2025
lib/src/gherkin/java/com/diffplug/spotless/glue/gherkin/GherkinUtilsFormatterFunc.java
Outdated
Show resolved
Hide resolved
Pankraz76
force-pushed
the
fix-rewrite-unused
branch
from
b79903c to
15c27e4
Compare
Pankraz76
commented
Jul 23, 2025
Pankraz76
commented
Jul 23, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Pankraz76
force-pushed
the
fix-rewrite-unused
branch
3 times, most recently
from
154a33d to
3ec6538
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Pankraz76
force-pushed
the
fix-rewrite-unused
branch
2 times, most recently
from
30aacb8 to
7c22a78
Compare
Pankraz76
changed the title
rewrite support for RemoveUnusedPrivateMethods & RemoveUnusedImportsrewrite support for errorprone.refasterrules.StringRulesRecipes
Pankraz76
commented
Jul 24, 2025
plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GradleIntegrationHarness.java
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Pankraz76
force-pushed
the
fix-rewrite-unused
branch
3 times, most recently
from
352806a to
d454ac9
Compare
nedtwigg
reviewed
Jul 24, 2025
Pankraz76
force-pushed
the
fix-rewrite-unused
branch
from
e954cca to
5be6fd9
Compare
|
rewrite takes 6m 55s on CI
FYI: |
Pankraz76
force-pushed
the
fix-rewrite-unused
branch
from
5be6fd9 to
3cea3a3
Compare
Pankraz76
force-pushed
the
fix-rewrite-unused
branch
from
3cea3a3 to
134a835
Compare
Pankraz76
force-pushed
the
fix-rewrite-unused
branch
from
134a835 to
bc88c83
Compare
This was referenced Aug 1, 2025
|
waiting for enabler: |
This was referenced Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding
refs:
value.trim().length() < 1tovalue.isBlank() < 1openrewrite/rewrite-apache#90rewritesupport forerrorprone.refasterrulesapache/kafka#20219fyi:
@gnodet
@iddeepak
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)